Bugzilla – Bug 10021
inputrc installation needs to be optional
Last modified: 2007-03-31 02:17:23 UTC
There should be a file in /etc called inputrc. Here's what is in mine (from an older ISO): # Begin /etc/inputrc # Make sure we don't output everything on the 1 line set horizontal-scroll-mode Off # Enable 8bit input set meta-flag On set input-meta On # Turns off 8th bit stripping set convert-meta Off # Keep the 8th bit for display set output-meta On # none, visible or audible set bell-style none # All of the following map the escape sequence of the # value contained inside the 1st argument to the # readline specific functions "\eOd": backward-word "\eOc": forward-word # for linux console "\e[1~": beginning-of-line "\e[4~": end-of-line "\e[5~": beginning-of-history "\e[6~": end-of-history "\e[3~": delete-char "\e[2~": quoted-insert # for xterm "\eOH": beginning-of-line "\eOF": end-of-line # End /etc/inputrc Also, there needs to be a file in /etc/profile.d called inputrc.sh with the following: #!/bin/bash # First check if this variable is already set # then if not set, check it (maybe), then set it if [ -z "$INPUTRC" ] ; then INPUTRC=/etc/inputrc fi export INPUTRC Maybe a spell should be created for it?
I agree (and have gotten complaints from others that we don't have it).
Perhaps an smgl-baselayout?
Does it fit in with anything else? It kinda seems like a trivial thing for one spell.... perhaps it should go with init.d ?
I was thinking we could use the smgl-baselayout to add other files in the future (/etc/hosts, /etc/passwd, /etc/group, etc.).
That's a great idea. That would fix our /etc/hosts issue too. Done yet? ;P
Hmm, not quite... the fun thing about /etc/hosts is that we need to add the hostname the user selected into it too.
readline spell has installed inputrc since a few months already. Readline is also imho the correct spell for this because readline is what uses inputrc anyway. I think this bug should be closed. But how about we open a new one for smgl-baselayout?
May want to so we don't forget. :) Probably one bug for each file.
Okay Eric, I'm shutting down this bug because I just verified what Juuso said about readline. I'm going to leave it up to you to generate the other bug(s).
The installation of /etc/inputrc needs to be made optional and default to 'n'. Things will work fine without it being there and believe it or not some people won't want it.
Moving to codex...
finish hijacking this bug...
Note that hacking INPUTRC breaks the default of ~/.inputrc. Specifying a global inputrc that way is wrong! The correct way is to have a .inputrc in the user skel for autocreation that contains '$input /etc/inputrc' as its first line. That way they get to modify inputrc locally and get global benefits. See bug 12888 for more details.
Sorry for this taking me so long! I've made readline's inputrc install optional in test with commit 43a2bd64c7a8f0120645c3196565dcef1fabcb7b. I'll refrain from marking this FIXED until an agreement has been reached about the details. See below: Seth, the readline.sh script that's installed along with /etc/inputrc only sets INPUTRC=/etc/inputrc if ~/.inputrc doesn't exist. So even when a system-wide inputrc is installed, users can override it by setting up a local one (which can also have '$include /etc/inputrc' in it). Does this sound acceptable to you?
I forgot to add the CONFIGURE file in that commit, now it's done with 8d789e3cac30cfe8cce0fd278f045f9db742bc6d.
anything left here to do (I don't see it)?
I'd say this is fixed. I was waiting for Seth to give his amen, but I think time's up :). The recent stable-rc has this edit, I'll mark this fixed in lesser branch and request for stable integration.
I was going to integrate this as well, but I get this error when cherry-picking the first commit: $ git cherry-pick 43a2bd64c7a8f0120645c3196565dcef1fabcb7b Cannot run cherry-pick a multi-parent commit.
yeah, it also contains the merge iuso did with upstream. git log -p 43a2bd64c7a8f0120645c3196565dcef1fabcb7b shows you actually want b8a7f24a3fde4288da21adde45570cb7eb15c288
Thanks. :) I also had to integrate 8d789e3cac30cfe8cce0fd278f045f9db742bc6d (actually adding CONFIGURE). Both 8d789e3cac30cfe8cce0fd278f045f9db742bc6d and b8a7f24a3fde4288da21adde45570cb7eb15c288 have been integrated to stable-0.4.
I'm reopening this because it looks like sandalle forgot to integrate the etc/ dir in stable's readline. It now has the query and installation code but nothing to install, leading to an error if the inputrc option is selected. See stable/libs/readline/ in http://codex.sourcemage.org/stable.tar.bz2
*** Bug 13384 has been marked as a duplicate of this bug. ***
Date: Wed Dec 6 10:41:25 2006 -0800 that's when it was added, so it didn't make it into the tarball (25.11.). Seth is working on regenerating it.
closing fixed bugs