Bug 13773 - [integrated] net-tools ifup shouldn't use ifconfig -a
: [integrated] net-tools ifup shouldn't use ifconfig -a
Status: CLOSED FIXED
Product: Codex
Classification: Unclassified
Component: net
: stable grimoire
: All Linux
: P2 normal
Assigned To: Grimoire Bug List
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-11 12:21 UTC by David Brown
Modified: 2007-05-19 09:11 UTC (History)
1 user (show)

See Also:
eric: fixed_in_lesser_branch+
eric: integrate_to_stable_grimoire-
eric: integrate_to_stable‑rc_grimoire+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Brown 2007-05-11 12:21:35 UTC
The function in the ifup script to check if the interface is up uses ifconfig -a
which lists both up and down interfaces. The function tries to pass the
arguments to grep looking for an inet addr but you can still have a 'down'
interface with a valid ip. I think this should be changed to ifconfig instead of
ifconfig -a.

This issue was found by using the xen networking scripts to setup a bridged
network. I had to modify the ifup script on my system in this way to make ifup
function the appropriate way so the network would work.
Comment 1 Andraž 'ruskie' Levstik 2007-05-11 12:34:49 UTC
This is what it should be using:
ifconfig $interface | grep -q " UP "
Comment 2 David Brown 2007-05-11 12:38:05 UTC
I think either ruskie's or my solution would be a valid replacement.
Comment 3 David Kowis 2007-05-14 17:53:16 UTC
I'm not sure what the precise bug process is, but I think I did this right. If
not, I'm requesting integration to the stable-rc and into stable, because it's
been broke for a really long time. 
Comment 4 David Kowis 2007-05-14 18:02:09 UTC
Oops forgot commit ID
abf1c680459fb0bba9db4718b4d2c9faaec21388
Comment 5 Eric Sandall 2007-05-14 18:05:52 UTC
Approving abf1c680459fb0bba9db4718b4d2c9faaec21388 for stable and stable-rc.
Comment 6 Eric Sandall 2007-05-14 23:40:59 UTC
Integrated to stable-rc-0.10 in commit b690f7bd781e601e04a8d14e824bc5566894036a

Denying stable as a new stable will be out within the week.
Comment 7 Jaka Kranjc 2007-05-19 09:11:58 UTC
closing out-of-stable bugs