Bug 2867 - Alsa-driver fails on Pentium 4 machines
: Alsa-driver fails on Pentium 4 machines
Status: CLOSED FIXED
Product: Codex
Classification: Unclassified
Component: audio
: devel grimoire
: Other other
: P2 normal
Assigned To: Grimoire Bug List
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2003-03-20 22:35 UTC by Gabriel Devenyi
Modified: 2007-04-01 01:09 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Devenyi 2003-03-20 22:35:59 UTC
The line sedit "s:\-O2:${CFLAGS}:" configure && causes pcm-oss.o to fail to build.
Comment 1 Eric Sandall 2003-03-25 19:36:25 UTC
Ahhh....so that's why it fails on my g/f's P4 ('course she has a faster computer than 
me :(). 
 
Should we have BUILD check the -mcpu line of CFLAGS, and if it's "pentium4", 
then don't run sedit, otherwise do? 
 
if  ! "cat  ${CFLAGS}|grep -q -mcpu"  = "-mcpu=pentium4" 
then 
  sedit  "s:\-O2:${CFLAGS}:"  configure  && 
fi 
 
Should work, haven't tested the above, but I did remove the sedit line and 
alsa-driver now compiles.  :) 
Comment 2 Gabriel Devenyi 2003-04-16 14:24:02 UTC
This fix is easy, available and works, is it going to happen? 
Comment 3 Andrew Stitt 2003-04-16 14:43:05 UTC
I applied the fix to devel, try casting it tomorrow (from devel) after the 
grimoire updates and let me know if it works.
Comment 4 Gabriel Devenyi 2003-04-27 23:57:29 UTC
Seems there's a syntax error somewhere in that fix. 
 
Using gcc version: 3.2.2 
Installing in dir: /usr/src/alsa-driver-0.9.2 
alsa-driver    0.9.2 
/tmp/casting.18621: /var/lib/sorcery/codex/devel/audio/alsa-driver/BUILD: line 31: syntax error 
near unexpected token `fi' 
/tmp/casting.18621: /var/lib/sorcery/codex/devel/audio/alsa-driver/BUILD: line 31: `fi' 
 ! Problem Detected !  
Creating /var/log/sorcery/compile/alsa-driver-0.9.2.bz2 
Comment 5 Eric Sandall 2003-04-28 22:26:46 UTC
Fixed the syntax in devel.
Comment 6 Gabriel Devenyi 2003-05-13 19:10:36 UTC
Build is still broken on p4's check the fix 
Comment 7 Eric Sandall 2003-05-13 19:47:34 UTC
What's the error you get?  With this fix it compiled fine on my g/f's PIV-1.8GHz.
Comment 8 Gabriel Devenyi 2003-05-14 18:20:08 UTC
This is second person information, I installed my friend's machine and submitted this bug based 
on his system, its a PIV 2.2GHz, I'm getting this info from him, perhpas its the awk error that I've 
been expereienceing but continuing the compile works, I'll have to talk to him again. 
Comment 9 Eric Sandall 2003-05-14 19:24:07 UTC
Which grimoire is he using?  Does he have the syntax error?  If so, have him do
a 'scribe update' and see if that fixes it, if not, set this bug to the
appropriate grimoire and I'll pull it through, though I believe the fix has been
pulled to test, at least.
Comment 10 Gabriel Devenyi 2003-05-15 21:58:05 UTC
Figured out what the error is, its a bug in gcc3.2 (http://gcc.gnu.org/PR10077) its fixed in 3.3 so 
we just need to wait for the merge. 
Comment 11 Gabriel Devenyi 2003-06-28 15:28:36 UTC
Seems this is fixed now 
Comment 12 Eric Sandall 2003-07-01 16:56:38 UTC
Should we remove the pentium4 fix code from BUILD then (and alsa-driver-virmidi)?
Comment 13 Gabriel Devenyi 2003-07-01 17:06:29 UTC
When I say fixed I mean that the fix implimented is good, it should not be 
removed. 
Comment 14 Eric Sandall 2003-07-01 17:20:51 UTC
gcc 3.3 didn't fix it?  I know the patch fixed it, but gcc 3.3 was supposed to
be fixed so that we wouldn't need to change our flags to compile anymore on a
pentium4 (it fixed the mozilla bug).
Comment 15 Gabriel Devenyi 2003-07-01 18:45:04 UTC
Whoops yeah forgot thats what the fix was for in the first place. Tested it on my 
friend's machine, works fine. So to change my answer YES the fix can be removed 
since GCC 3.3 fixes the compile bug. 
Comment 16 Eric Sandall 2003-07-01 19:04:38 UTC
Done, thanks.  :)
Comment 17 Eric Sandall 2003-07-03 18:15:17 UTC
Closure....
Comment 18 Jeremy Blosser 2007-04-01 00:09:15 UTC
reassign to sm-grimoire-bugs