Bug 7863 - ilohamail installs to DocumentRoot
: ilohamail installs to DocumentRoot
Status: CLOSED FIXED
Product: Codex
Classification: Unclassified
Component: mail
: stable grimoire
: All Linux
: P2 major
Assigned To: Grimoire Bug List
Depends on:
Blocks: 8671
  Show dependency treegraph
 
Reported: 2004-12-21 02:48 UTC by Laurent Wandrebeck
Modified: 2007-04-01 01:20 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Wandrebeck 2004-12-21 02:48:46 UTC
# apache htdoc path auto detection
  if  spell_installed    "apache";   then
    LOC="/usr/share/httpd/htdocs/$SPELL"
  elif  spell_installed  "apache-mod_ssl";  then
    LOC="/usr/share/httpsd/htdocs/$SPELL"
  elif  spell_installed  "apache2";  then
    LOC="/usr/share/apache2/htdocs/$SPELL"

that is plain wrong, as some admin may have changed DocumentRoot.
Could we use something like that to get the right path:
cat /etc/httpd/httpd.conf | grep DocumentRoot\ \" | cut -d\" -f 2

Moer over, i keep getting when casting IlohaMail:
/tmp/sorcery/cast/24429/casting.safe: line 29: /etc/init.d/apache.sh: No such
file or directory
which looks like clearly a bug :-)
investigating why...found.
in POST_INSTALL, at the end of the file, please change /etc/init.d/apache.sh to
/etc/init.d/runlevels/%3/apache
thx.
Well, last addition: please update that thing:
http://sourceforge.net/projects/ilohamail/ shows 0.8.9 as devel, and 0.8.14-RC1
as stable.
regards
Comment 1 Laurent Wandrebeck 2004-12-21 05:29:05 UTC
Would you please too avoid to install it in DocumentRoot, and change ownership
of the whole tree ?
thx.
btw, i'm running right now stable version as indicated in my previous comment,
runs fine.
regards.
Comment 2 Adam "Kinetix" Clark 2004-12-21 21:43:52 UTC
Since one can not play guessing games with things like apache conf files after 
it's been installed, there's no real way to figure out what DocumentRoot one 
should place this kind of software in.  Hence, the default makes the most sense 
(and is probably why all the other spells of this type do the same thing - have 
a look at squirrelmail, or openwebmail). 
 
Once the software exists in the 'default' location, the administrator is free 
to copy away, or simply run it from the default location. 
 
At any rate, I've done the version bump to the spell, but don't really see how 
the rest has any need to be 'fixed'. 
Comment 3 Laurent Wandrebeck 2004-12-26 11:42:17 UTC
Ok, you don't want to check the right location of DocumentRoot.
That'll bork tracking if real documentroot is anywhere else, because I suppose
the admin would mv and not cp files :(
And what about install commands ? Couldn't you install squirrelmail, IlohaMail
in a subdirectory of DocumentRoot ? Acting like the spell does currently doesn't
take care at all of potentially already present files. That's a shame since it
could replace other files etc. And make by the way a couple guys quite upset.
All in all, putting it in a subdirectory could save files and avoid the spell to
change the ownership of the whole website.
Your opinion ?
Comment 4 Laurent Wandrebeck 2005-01-19 05:28:53 UTC
I'd like to add too that 0.8.14-RC2 is out, (security fixes).
Comment 5 Laurent Wandrebeck 2005-04-18 08:32:41 UTC
IlohaMail 0.8.14-RC3 Released, security fixes. please update.
Comment 6 Laurent Wandrebeck 2005-04-19 03:37:22 UTC
CC'ing security team lead, as nothing evolved for months.
Comment 7 Thomas Houssin 2005-04-19 04:01:38 UTC
I'll have a look on that quickly...
Comment 8 Jeremy Blosser 2005-04-19 21:49:03 UTC
Updated in devel, can someone with php verify?  Thomas, can you get it into
stable once it's verified?
Comment 9 Eric Sandall 2005-04-23 15:16:41 UTC
For DocumentRoot, the packages should probably install themselves to
/usr/share/<spell> and the admin can add the proper flags to httpd.conf to
include them. Or setup his own symlinks.
Comment 10 Jeremy Blosser 2005-04-23 21:40:16 UTC
The security fix is in test, it needs to go to stable...
Comment 11 Thomas Houssin 2005-04-24 04:09:47 UTC
Updated in stable, now we can take care of this DocumentRoot problem...
Comment 12 Eric Sandall 2005-04-24 08:29:13 UTC
I've changed the Summary and added a dependency on Bug #8671. That is the master
bug for spells that use DocumentRoot improperly. I will go through as I have
time and file bugs for spells that do this so we can fix them. The bug is filed
against stable because I think this is an important issue (managing and changing
files in a user's htdocs is a Bad Thing(TM)).
Comment 13 David Kowis 2006-02-09 11:56:08 UTC
Reassigning these to me, because I don't have the mail@sourcemage.org email
alias pointed to me :)
Comment 14 David Kowis 2006-03-13 13:17:33 UTC
Fixed in test
Comment 15 David Kowis 2006-03-13 14:18:52 UTC
I can verify this one: It does install to /usr/share/www/ilohamail now
Comment 16 David Kowis 2006-03-13 14:18:58 UTC
Bug closing time.
Comment 17 Jeremy Blosser 2007-04-01 00:20:49 UTC
reassign to sm-grimoire-bugs